[draft]vkd-heartbeat: Add execution API to vdk heartbeat #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we need such a test? Please, describe the aim of the change and why it is needed (git template) This is really important in order to be able to conduct an efficient review. By writing out what is the problem being solved in this change, we make it explicit to reviewers and readers what is in the scope of our change and what it is not. Thus avoiding any potential misunderstanding. |
|
How much time did the test takes now? We need to be careful to keep the test duration under control. How did you test it ? I see no testing done in the description. You can bump version vdk-heartbeat to trigger release upon merge. |
mrMoZ1
force-pushed
the
person/mzhivkov/add-execute-api
branch
from
a368fab to
25df9b5
Compare
projects/vdk-heartbeat/src/taurus/vdk/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
projects/vdk-heartbeat/src/taurus/vdk/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
mrMoZ1
force-pushed
the
person/mzhivkov/add-execute-api
branch
5 times, most recently
from
37a2d49 to
0eb802d
Compare
antoniivanov
approved these changes
Aug 23, 2021
projects/vdk-heartbeat/src/taurus/vdk/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
projects/vdk-heartbeat/src/taurus/vdk/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
Recently we added a new execution api to the control service. This change aims to include the new api functionality in the vdk-heartbeat tests. This change adds the new functionality of the execute API to the VDK heartbeat tests. We now have functionality to check if a data job has a running data jobexecution and start a data job execution through job_controller.py The new test flow disables the data job deployment after all other tests have passed and then checks for a runnig execution. When there are none we start a new data job execution through the execution API, and checks that the data job execution has started. Since the deployment was disabled the only data job execution that could start is a manual one through the execution api. Once that execution finishes the test concludes and execution resources get cleaned up as normal. Testing: CI/CD Signed-off-by: Momchil Zhivkov <[email protected]>
mrMoZ1
force-pushed
the
person/mzhivkov/add-execute-api
branch
from
0eb802d to
ec58436
Compare
kostoww
pushed a commit
that referenced
this pull request
Aug 29, 2021
Recently we added a new execution api to the control service. This change aims to include the new api functionality in the vdk-heartbeat tests. This change adds the new functionality of the execute API to the VDK heartbeat tests. We now have functionality to check if a data job has a running data jobexecution and start a data job execution through job_controller.py The new test flow disables the data job deployment after all other tests have passed and then checks for a runnig execution. When there are none we start a new data job execution through the execution API, and checks that the data job execution has started. Since the deployment was disabled the only data job execution that could start is a manual one through the execution api. Once that execution finishes the test concludes and execution resources get cleaned up as normal. Testing: CI/CD Signed-off-by: Momchil Zhivkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we added a new execution api to the control service.
This change aims to include the new api functionality in the
vdk-heartbeat tests.
This change adds the new functionality of the execute API to the
VDK heartbeat tests. We now have functionality to
check if a data job has a running data jobexecution
and start a data job execution through job_controller.py
The new test flow disables the data job deployment after all other
tests have passed and then checks for a runnig execution.
When there are none we start a new data job execution through the
execution API, and checks that the data job execution has started. Since
the deployment was disabled the only data job execution
that could start is a manual one through the execution api.
Once that execution finishes the test concludes and execution
resources get cleaned up as normal.
Testing: CI/CD
Signed-off-by: Momchil Zhivkov [email protected]